Fix paginate() to avoid redundant get_breads() queryset evaluation#668
Open
Kkt04 wants to merge 1 commit intowagtail:mainfrom
Open
Fix paginate() to avoid redundant get_breads() queryset evaluation#668Kkt04 wants to merge 1 commit intowagtail:mainfrom
Kkt04 wants to merge 1 commit intowagtail:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #664
BreadsIndexPage.paginate()accepted*argsbut never used them. It was called inget_context()withself.get_breads()passed as an argument:https://github.com/wagtail/bakerydemo/blob/63c1e81/bakerydemo/breads/models.py#L256-L257
But
paginate()silently ignored the argument and calledself.get_breads()internally again:https://github.com/wagtail/bakerydemo/blob/63c1e81/bakerydemo/breads/models.py#L239-L245
This resulted in two queryset evaluations (two database queries) on every
/breads/page load — one wasted.Changes
*argswith explicitqueryset=Noneparameter inpaginate()paginate()now uses the passed queryset or falls back toself.get_breads()get_context()— no longer passesself.get_breads()as argumentget_breads()is now called only once per request